Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose divisor setting in helm #11991

Open
lukidzi opened this issue Nov 7, 2024 · 2 comments
Open

Expose divisor setting in helm #11991

lukidzi opened this issue Nov 7, 2024 · 2 comments
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lukidzi
Copy link
Contributor

lukidzi commented Nov 7, 2024

Description

We set GOMAXPROCSand GOMEMLIMIT and some user might want to configure for them divisor.
We should expose the option to configure it

            - name: GOMEMLIMIT
              valueFrom:
                resourceFieldRef:
                  containerName: control-plane
                  resource: limits.memory
                  divisor: "1"
            - name: GOMAXPROCS
              valueFrom:
                resourceFieldRef:
                  containerName: control-plane
                  resource: limits.cpu
                  divisor: "1"

By default we should set it to 1

@lukidzi lukidzi added triage/pending This issue will be looked at on the next triage meeting kind/improvement Improvement on an existing feature labels Nov 7, 2024
@voidlily
Copy link
Contributor

voidlily commented Nov 7, 2024

i'm also having an issue with argocd diffing on the divisor because there's no default set for it.

                 resourceFieldRef:
                   containerName: control-plane
-                  divisor: '0'
                   resource: limits.memory
             - name: GOMAXPROCS
                 resourceFieldRef:
                   containerName: control-plane
-                  divisor: '0'
                   resource: limits.cpu
           image: >-

similar issue as cilium/cilium#30634?

@voidlily
Copy link
Contributor

voidlily commented Nov 7, 2024

For anyone following along, workaround in argo is like this

  ignoreDifferences:
    - group: apps
      kind: Deployment
      jqPathExpressions:
        - '.spec.template.spec.containers[0].env[]?.valueFrom.resourceFieldRef.divisor'

@lukidzi lukidzi added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

No branches or pull requests

2 participants