Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate HealthyPanicThreshold for MeshHealthCheck policy #11938

Open
Icarus9913 opened this issue Oct 30, 2024 · 1 comment
Open

Deprecate HealthyPanicThreshold for MeshHealthCheck policy #11938

Icarus9913 opened this issue Oct 30, 2024 · 1 comment
Assignees
@Icarus9913
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it
Milestone
2.10.x

Comments

@Icarus9913
Copy link
Contributor

Icarus9913 commented Oct 30, 2024 •
edited
Loading

Description

The HealthyPanicThreshold property is a common configuration for the envoy config.cluster.v3.Cluster.CommonLbConfig. It seems more appropriate in MeshCircuitBreaker policy because it's more often used than MeshHealthCheck.

We should deprecate it rather than keep it for both policies, otherwise we hit some conflicts.

Steps from Charly:

  • Deprecate in MeshHealthcheck
  • Document in MeshHealthcheck doc that MeshCircuitBreaker can be used to modify panic threshold
  • During transition make MeshCircuitBreaker override MeshHealthCheck if both are set
@Icarus9913 Icarus9913 added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Oct 30, 2024
@Icarus9913
Copy link
Contributor Author

Refer to #11704

@Icarus9913 Icarus9913 added this to the 2.10.x milestone Oct 30, 2024
@bartsmykla bartsmykla added triage/accepted The issue was reviewed and is complete enough to start working on it kind/improvement Improvement on an existing feature and removed triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Icarus9913 Icarus9913

Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
2.10.x
Development

No branches or pull requests
2 participants
@bartsmykla @Icarus9913