Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike: decide how to run PolicyGroups using kwctl #906

Closed
Tracked by #798
flavio opened this issue Sep 6, 2024 · 5 comments
Closed
Tracked by #798

Spike: decide how to run PolicyGroups using kwctl #906

flavio opened this issue Sep 6, 2024 · 5 comments
Assignees
Milestone

Comments

@flavio
Copy link
Member

flavio commented Sep 6, 2024

Starting from Kubewarden 1.17 a new type of policy is introduced: PolicyGroup. The purpose and details of this policy type are covered by this dedicated RFC.

The purpose of this issue is to define how kwctl run should be used to run PolicyGroup.

@flavio flavio added this to the 1.17 milestone Sep 6, 2024
@viccuad viccuad changed the title Spike: decide how to run GroupPolicy using kwctl Spike: decide how to run PolicyGroups using kwctl Sep 11, 2024
@flavio flavio moved this to Todo in Kubewarden Sep 13, 2024
@flavio flavio modified the milestones: 1.17, 1.18 Sep 20, 2024
@fabriziosestito
Copy link
Contributor

Instead of creating a separate command for policy groups, we could add a new flag to the run command that takes a CRD as an input. e.g. kwctl run --crd policy_group.yaml or kwct run --crd policy.yaml
The supported CRD are all the policies CRD, including policy groups.

Prerequisite: We need to move the expression evaluation logic from the policy server crate to the policy evaluator crate.

@flavio
Copy link
Member Author

flavio commented Oct 23, 2024

I like this approach because it also provides a generic way to run any kind of Kubewarden CRD outside of the cluster, just for testing purposes.

@flavio flavio modified the milestones: 1.18, 1.19 Oct 23, 2024
@viccuad
Copy link
Member

viccuad commented Oct 23, 2024

Agree also.

@flavio flavio moved this from Pending review to Todo in Kubewarden Oct 23, 2024
@jvanz
Copy link
Member

jvanz commented Oct 28, 2024

Yeap, nice approach! 👍

@flavio
Copy link
Member Author

flavio commented Nov 4, 2024

Closing, I've created a dedicated issue for implementing what we've agreed. See #967

@flavio flavio closed this as completed Nov 4, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Kubewarden Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants