Feature Request: Handle updates from -rcX to -rcX+1 in Update chart job

[viccuad]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

On PR #220,
With job https://github.com/kubewarden/helm-charts/actions/runs/4692840686,
Which is a new release for appVersion 1.6.0-rc6, from appVersion 1.6.0-rc5,

The automation incorrectly bumped the minor version of the charts.
This may be because the automation doesn't know that we are updating from an RC (rc5 to rc6), so then it bumps the minor version.

The automation incorrectly left appVersion of 1 chart without bumping. This may be because that chart didn't have new changes. (E.g: 79c35db).

Expected Behavior

The automation should only bump the rc suffix in version and appVersion.

In addition, the automation should also bump the rc suffix even for those charts that don't contain new changes, so all charts have the same suffix (e.g: -rc6). This means that all the catalog.cattle.io/auto-install will also be up-to-date. (e.g: )

[viccuad]

Just reproduced this in #404,

With everything tagged as v1.11.0-rc5,
Being kwctl the last release to go through which triggered the first succesful helm-chart update-charts job,
With update-charts having oldVersion v1.10.1 and version v1.11.0-rc5 (see here),
The update-charts job went through "major or minor update" step instead of "prerelease update"
A new helm-charts PR was opened.

[viccuad]

This seems to now be fixed.

For the update of 1.12.0-rc1 to 1.12.0-rc2, the automation wrongly reused an already existing PR:
#428

Closed that PR manually, and retriggered the automation with workflow_dispatch, version v1.12.0-rc2 oldversion v1.12.0-rc1.
A completely correct PR was created:
#429

[viccuad]

This isn't fixed, as it just happened from v1.15.0-rc1 to v1.15.0-rc2.
See #490 (review) and the commit that I needed to add, 6f7408a.

[viccuad]

I think I found the culprit.

When updating from v1.16.0-rc2 to v1.16.0, the current updatecli config always bump the chart version as configured (which is incorrect). See here:
https://github.com/kubewarden/helm-charts/actions/runs/10450178469/job/28934023521#step:9:125

This is because the updatecli config that we use is the same for major, minor and prerelease, and does an increment on the updatecli source here:

helm-charts/updatecli/updatecli.d/major-kubewarden-update.yaml

Line 39 in 774cc44

- semverinc: "{{ requiredEnv .semverinc }}"

Note that this is for config updatecli.d/major-kubewarden-update.yaml, the same would happen for updatecli.d/major-kubewarden-update-with-crd-update.yaml.

A simple fix would be to add 2 new configs:

• updatecli/updatecli.d/rc-to-ga-kubewarden-update.yaml
• updatecli/updatecli.d/rc-to-ga-kubewarden-update-with-crd-update.yaml
  And logic in the GHA workflow to use them when we move to the same version without an rc suffix (e.g: v1.16.0-rc2 to v1.16.0, or v1.16.3-rc3 to v1.16.3).