Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move env to _const. #2455

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

redscholar
Copy link
Collaborator

What type of PR is this?

/kind design

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

move env to _const.

Additional documentation, usage docs, etc.:


@kubesphere-prow kubesphere-prow bot added release-note kind/design Categorizes issue or PR as related to design. labels Nov 13, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: redscholar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubesphere-prow kubesphere-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 13, 2024
Copy link

sonarcloud bot commented Nov 13, 2024

@pixiake
Copy link
Collaborator

pixiake commented Nov 13, 2024

/lgtm

@kubesphere-prow kubesphere-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2024
Copy link

LGTM label has been added.

Git tree hash: 3b6f4d3c9ccc85088d7482ffc7cfaa8d941b4188

@kubesphere-prow kubesphere-prow bot merged commit b79482a into kubesphere:feature-gitops Nov 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/design Categorizes issue or PR as related to design. lgtm Indicates that a PR is ready to be merged. release-note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants