Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the VPA's local dev and test scripts #7455

Open
2 of 4 tasks
adrianmoisey opened this issue Nov 4, 2024 · 2 comments
Open
2 of 4 tasks

Improve the VPA's local dev and test scripts #7455

adrianmoisey opened this issue Nov 4, 2024 · 2 comments
Assignees
Labels
area/vertical-pod-autoscaler kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@adrianmoisey
Copy link
Member

adrianmoisey commented Nov 4, 2024

The VPA's scripts for running e2e tests locally are out dated and don't work on modern Apple Silicon Macs.

There are also some quality of life improvements that could be done to make testing and local dev easier and neater, for example this 15 minute sleep could be improved on.

I plan to start tidying this area of the VPA up, making it easier and better to run tests.

/area vertical-pod-autoscaler
/assign

Some ideas:

  1. Make e2e tests run locally ✅
  2. Speed up e2e tests (some sleeps don't make much sense to keep) ✅
  3. Remove unnecessary logs (lots of warnings are outputted)
  4. Improve documentation on running tests
  5. Improve scripts (how much reusability can we get between local and non-local e2e scripts?)
  6. Bump metrics-server

Tasks

  1. approved area/vertical-pod-autoscaler cncf-cla: yes kind/cleanup lgtm size/S
    Shubham82 kwiesmueller
    omerap12
  2. approved area/vertical-pod-autoscaler cncf-cla: yes kind/cleanup lgtm size/L
    MaciekPytel kwiesmueller
    omerap12
  3. area/vertical-pod-autoscaler cncf-cla: yes kind/cleanup lgtm size/M
    omerap12
  4. area/vertical-pod-autoscaler cncf-cla: yes kind/cleanup lgtm size/M
    adrianmoisey
@adrianmoisey adrianmoisey added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 4, 2024
@adrianmoisey
Copy link
Member Author

/kind cleanup
/remove-kind feature

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Nov 4, 2024
@Shubham82
Copy link
Contributor

/triage accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vertical-pod-autoscaler kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants