Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(KONFLUX-1054): Setup defaults for ARTIFACT_DIR in max-concurrency load tests #1301

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(KONFLUX-1054): Setup defaults for ARTIFACT_DIR in max-concurrency load tests #1301

wants to merge 1 commit into from
+7 −0

Conversation

rh-rahulshetty
Copy link
Collaborator

Changes

  • Setup and create ARTIFACT_DIR in max-concurrency load test scenario as part result collector script.
  • Update .gitignore entries for skipping test related artifacts.

Issue ticket number and link

Found the issue while testing: https://issues.redhat.com/browse/KONFLUX-1054

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested the fix locally on running the max-concurrency tests on Hive OpenShift cluster.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 1, 2024

Hi @rh-rahulshetty. Thanks for your PR.

I'm waiting for a konflux-ci member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rh-rahulshetty rh-rahulshetty changed the title KONFLUX-1054: Setup defaults for ARTIFACT_DIR in max-concurrency load tests fix KONFLUX-1054: Setup defaults for ARTIFACT_DIR in max-concurrency load tests Aug 1, 2024
@rh-rahulshetty rh-rahulshetty changed the title fix KONFLUX-1054: Setup defaults for ARTIFACT_DIR in max-concurrency load tests fix(KONFLUX-1054): Setup defaults for ARTIFACT_DIR in max-concurrency load tests Aug 1, 2024
jhutar
jhutar approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@jhutar jhutar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 20, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhutar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jhutar
Copy link
Collaborator

jhutar commented Sep 5, 2024

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhutar jhutar jhutar approved these changes

Assignees

@jhutar jhutar

Labels
approved lgtm needs-ok-to-test < 1 min
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rh-rahulshetty @jhutar