Skip to content
This repository has been archived by the owner on Aug 31, 2024. It is now read-only.

Add http2 support #48

Open
doug-wade opened this issue Sep 6, 2017 · 4 comments · Fixed by #49
Open

Add http2 support #48

doug-wade opened this issue Sep 6, 2017 · 4 comments · Fixed by #49
Assignees

Comments

@doug-wade
Copy link
Collaborator

Http2 has landed in node.js. We should add support.

@nickserv
Copy link
Member

nickserv commented Sep 6, 2017

The API level for it is 1 (experimental), we might want to wait until this changes to put it in a stable release. Also, does this replace #16 or should we still fix that first?

@doug-wade
Copy link
Collaborator Author

doug-wade commented Sep 6, 2017

I don't think we should wait, I think we should add the feature now but make sure its completely optional, so clients can test and develop against the http2 api sooner without having to risk it in prod.

@nickserv
Copy link
Member

nickserv commented Sep 6, 2017

Good point, though I don't think we should make this block any releases until it's no longer experimental.

@doug-wade doug-wade self-assigned this May 10, 2018
@doug-wade
Copy link
Collaborator Author

Afaict, this is a documentation-only fix. Iiuc, since we extend koa, clients should be able to follow these instructions and have http2 support. I'm going to test and document.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants