Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for Source.spec.ceOverride.extension names that are longer than 20 characters and with uppercase letters #2258

Open
gabo1208 opened this issue Sep 2, 2021 · 3 comments
Labels
triage/accepted Issues which should be fixed (post-triage)

Comments

@gabo1208
Copy link
Member

gabo1208 commented Sep 2, 2021

Problem
As stated on the Cloud Events Spec
the attribute naming convention suggest (SHOULD, not MUST) that the names are no longer than 20 characters. We should add at maybe a warning for that cases, even when this does not imply an error. Also, when there are keys with upper case letters there could be a collision (cause the keys get converted to lower-case), in that keys the value corresponds with the last defined key (generally)

Persona:
Producers, consumers and integrators

Exit Criteria
When you set an extension name longer than 20 characters on any source.spec.ceOverride.extensions extension, the logs show a warning about that extension name

Additional context (optional)
Here should be any warning or validation related to sources 😉

@gabo1208 gabo1208 changed the title Add warning for Source.spec.ceOverride.extension names that are longer than 20 characters Add warning for Source.spec.ceOverride.extension names that are longer than 20 characters and with collision names Sep 3, 2021
@gabo1208 gabo1208 changed the title Add warning for Source.spec.ceOverride.extension names that are longer than 20 characters and with collision names Add warning for Source.spec.ceOverride.extension names that are longer than 20 characters and with uppercase letters Sep 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2021

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 3, 2021
@github-actions github-actions bot closed this as completed Jan 2, 2022
@pierDipi
Copy link
Member

pierDipi commented Jan 3, 2022

/remove-lifecycle stale
/triage accepted
/reopen

@knative-prow-robot knative-prow-robot added the triage/accepted Issues which should be fixed (post-triage) label Jan 3, 2022
@knative-prow-robot
Copy link
Contributor

@pierDipi: Reopened this issue.

In response to this:

/remove-lifecycle stale
/triage accepted
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

No branches or pull requests

3 participants