Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expanding Visibility Setting #198

Open
nak3 opened this issue Nov 21, 2021 · 3 comments
Open

Expanding Visibility Setting #198

nak3 opened this issue Nov 21, 2021 · 3 comments
Labels
kind/feature-request lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@nak3
Copy link
Contributor

nak3 commented Nov 21, 2021

The background is described in original issue - knative/serving#6642
The original design introduced Realm and Domain CRDs but it stopped developing as the design is difficult to align with Ingress v2 (Gateway API).

The new Gateway API controller has visibility based setting (it maps one Visibility to one Gateway) like:

https://github.com/knative-sandbox/net-gateway-api/blob/9218e0d7ff957b2ea4ec106abfdd018988bf72a3/config/config-gateway.yaml#L42-L50

So it will be possible to achieve the goal what knative/serving#6642 tried to address.
@nak3
Copy link
Contributor Author

nak3 commented Nov 21, 2021

This should be worked on Gateway API v0.4.0 or later as Gateway API still changes the design.

@nak3 nak3 moved this to Later in Networking WG Roadmap Nov 21, 2021
nak3 added a commit to nak3/serving that referenced this issue Dec 6, 2021
@nak3
Relax label validation for networking.knative.dev/visibility
8150054 
This patch removes `networking.knative.dev/visibility` validation.
Curently only `cluster-local` can be specified.

Fix knative#8185
Part of knative-extensions/net-gateway-api#198
@nak3 nak3 mentioned this issue Dec 6, 2021
Merged
nak3 added a commit to nak3/serving that referenced this issue Dec 6, 2021
@nak3
Relax label validation for networking.knative.dev/visibility
7672a48 
This patch removes `networking.knative.dev/visibility` validation.
Curently only `cluster-local` can be specified.

Fix knative#8185
Part of knative-extensions/net-gateway-api#198
nak3 added a commit to nak3/serving that referenced this issue Dec 6, 2021
@nak3
Relax label validation for networking.knative.dev/visibility
469e0b5 
This patch removes `networking.knative.dev/visibility` validation.
Curently only `cluster-local` can be specified.

Fix knative#8185
Part of knative-extensions/net-gateway-api#198
knative-prow-robot pushed a commit to knative/serving that referenced this issue Dec 8, 2021
@nak3
Relax label validation for networking.knative.dev/visibility (#12397)
1537e0b 
This patch removes `networking.knative.dev/visibility` validation.
Curently only `cluster-local` can be specified.

Fix #8185
Part of knative-extensions/net-gateway-api#198
@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 20, 2022
@nak3 nak3 added this to the v1.4.0 milestone Feb 21, 2022
@nak3 nak3 moved this from In Design to Ready To Work in Networking WG Roadmap Mar 7, 2022
@nak3 nak3 added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 10, 2022
@nak3 nak3 modified the milestones: v1.4.0, v1.6.0 Jun 10, 2022
@carlisia carlisia modified the milestones: v1.6.0, v1.7.0 Aug 5, 2022
@dprotaso dprotaso removed this from the v1.7.0 milestone Nov 29, 2022
@dprotaso
Copy link
Contributor

dprotaso commented Apr 2, 2024

Following up here we may want to add similar functionality that just landed in the net-istio about a greater control of gateway selection

Details in the feature track https://docs.google.com/document/d/12X1-9nhjAhpf-Wlt3RbdoMbvx31zFBva/edit?pli=1#heading=h.gjdgxs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature-request lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@carlisia @dprotaso @nak3