Elide endpoint probes when the set of services does not change #410
Labels
lifecycle/frozen
Indicates that an issue or PR should not be auto-closed due to staleness.
triage/accepted
Issues which should be fixed (post-triage)
A good example of this would be updating
traffic:
to change percentages (or @vagababov new gradual rollouts) where the set of services ingeneration: X
andgeneration: X+1
are identical.We get the former from
oldGeneration
and the latter froming
here: https://github.com/knative-sandbox/net-contour/blob/7bff03576e1c01114d47c0fdc58dac74a98115db/pkg/reconciler/contour/contour.go#L119The simplest correct solution is that when the set of services is identical per visibility to elide the endpoint probe, but we could perhaps optimize more generally by excluding services present in both sets and simply eliding when that leaves the empty set 🤔
The text was updated successfully, but these errors were encountered: