Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constant ok messages #1441

Open
Tigerwraith opened this issue Aug 4, 2024 · 9 comments
Open

constant ok messages #1441

Tigerwraith opened this issue Aug 4, 2024 · 9 comments

Comments

@Tigerwraith
Copy link

Since I updated from stock Creality firmware from https://github.com/mriscoc/Ender3V2S1 for my Ender. The command window has a constant ok messages populating while the printer is printing. Is there a way to turn these off or filter them out?
image

@DivingDuck
Copy link
Collaborator

DivingDuck commented Aug 22, 2024

@Tigerwraith
sorry for the late response. What version of Pronterface do you run?
There is no filter function available. This do lotnot look like you have enable debug communications. This is maybe a setup in your firmware or printer setup you can change.

Edit: correct typo

@Tigerwraith
Copy link
Author

@DivingDuck I am running 2.1.0. I did only start to see this once I moved to the new firmware.

@DivingDuck
Copy link
Collaborator

Thanks for the Info.
It is maybe a good idea to ask the people who build this firmware why the behavior change and how you can prevent this continuous logging/debugging information.

Here is something you might like to check: https://marlinfw.org/docs/gcode/M111.html

@DivingDuck
Copy link
Collaborator

@Tigerwraith,
I guess we can close this issue. There is actual no plan for filtering communication messages in addition to what is implemented with debug communication. I'm not sure if this really makes any sense for Pronterface for a future update as this kind of logging only introduce a hell lot of traffic in communication. In addition it looks for me redundant to the implemented send&receive check via checksum for each line send to the printer.

@rockstorm101 @kliment,
any though from your point of view?

Best regards,
DD

@rockstorm101
Copy link
Collaborator

@rockstorm101 @kliment,
any though from your point of view?

Well, here are my two cents.

  • After a quick look to OP's image seems like it is sending a command in the form P0 B15 which I could not find any documentation for. So it seems the slicer is injecting that command onto the G-code file and the printer firmware is (somehow) accepting it.
  • Does it send the ok ... message for every single command? Maybe debug communications was turned on by mistake? And it is as simple as turning it off
  • On the other hand, if the ok ... message is being displayed only for commands like P0 B15 then we (Pronterface) have an issue because we should not be displaying those "ok" messages when not in debug mode. In which case I would not close the issue yet since something is going on on our side.

All that being said, I guess we would need:

  • What slicer is being used?
  • A full log would be nice or at least answers to the questions above
  • I guess it happens on all prints, otherwise a file that produces the reported behavior

Again, I'm sorry it took me this long to look into this.

@Tigerwraith
Copy link
Author

I have since moved on from using Marlin2 to Klipper on my Ender. I was using Orca Slicer (I have now moved to Bambu Slicer due to stringing issues using Orca)

It seemed to me that the ok message was for every single command not just specific ones.
This is what the creator of the firmware had said to me,
image
I never did get around to compiling the firmware with that advance feature turned off so I do not know if it worked.

@DivingDuck
Copy link
Collaborator

Marlin doc: ADVANCED_OK:

Advanced OK

//#define ADVANCED_OK

Include extra information about the buffer in “ok” messages. Some hosts will have this feature soon.
This could make the NO_TIMEOUTS unnecessary.

And here is a information for a OctoPrint plugin that uses this output.
Mentioning: https://community.octoprint.org/t/a-list-of-recommended-marlin-features/39048
Plugin: https://github.com/chendo/BufferBuddy

@rockstorm101
Copy link
Collaborator

It seemed to me that the ok message was for every single command not just specific ones.
This is what the creator of the firmware had said to me,

Aha! Finally some light regarding the mysterious ok N#### P# B# messages. It's a Marlin thing. I'd say we definitely need to handle those better, otherwise we'll get more issues on this regard.

I have since moved on from using Marlin2 to Klipper on my Ender.

I assume you don't see the messages any more then?

@Tigerwraith
Copy link
Author

Well no I don't as I don't use pronterface any more. Klipper and Mainsail now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants