Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation - Translate to Korean #136

Open
pmj-chosim opened this issue Oct 3, 2024 · 5 comments
Open

Documentation - Translate to Korean #136

pmj-chosim opened this issue Oct 3, 2024 · 5 comments
Labels
documentation Improvements or additions to documentation hacktoberfest Hacktoberfest!

Comments

@pmj-chosim
Copy link

pmj-chosim commented Oct 3, 2024

Translate the documentation site to Korean.

@pmj-chosim
Copy link
Author

I'm on it:)

@pmj-chosim
Copy link
Author

pmj-chosim commented Oct 3, 2024

Could you tell me where I put my localization readme(directory)?

*Localization readme: https://github.com/pmj-chosim/astro-shield/blob/ko-kr-localization/README.md

@castarco castarco added documentation Improvements or additions to documentation hacktoberfest Hacktoberfest! labels Oct 3, 2024
@castarco
Copy link
Contributor

castarco commented Oct 3, 2024

Hi @pmj-chosim , great to see that you are on it 😄 .

Some things that you should check:

  • docs/astro.config.mjs
  • docs/src/content/docs/[LANG_OF_CHOICE]: This one should contain a structure almost identical to what's inside docs/src/content/docs/ (except, of course, the other translations).

If it's ok for you, you can make it simple and just use the language code, I'm not sure that will have enough contributors to also consider local dialects.

@castarco
Copy link
Contributor

castarco commented Oct 3, 2024

Oh, sorry. You were wondering about the README file itself... hmm... that's something I didn't think about yet. Until now I was only worried about the website (https://astro-shield.kindspells.dev), which is deployed from what's inside docs/.

I should probably rename the docs/ directory into something like website/, and then leave docs/[LANG_CODE] for copies of the typical README.md, CONTRIBUTING.md, and other files alike commonly present at the root of the repository.

@pmj-chosim
Copy link
Author

pmj-chosim commented Oct 7, 2024

How about creating a folder named l10n and placing my localization README file in it as ko-kr-README.md?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation hacktoberfest Hacktoberfest!
Projects
None yet
Development

No branches or pull requests

2 participants