Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the sort AccountId, don't use -1 as special signal #36

Open
ehildenb opened this issue Nov 29, 2018 · 0 comments
Open

Remove the sort AccountId, don't use -1 as special signal #36

ehildenb opened this issue Nov 29, 2018 · 0 comments

Comments

@ehildenb
Copy link
Member

AFAIK, the AccountId sort is not needed, instead when we have an undefined account we can just use #undef_account or .Account in the Account sort instead.

Reasoning by extending the builtin sorts will definitely blow up.

Similarly, the newest version uses -1 as a "signal" value for undefined accounts. This will definitely make symbolic reasoning very difficult. It's better to not touch the builtin reasoning sorts (eg. Int or Id) at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant