-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Hero Image Not Responsive on Mobile #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you and congratulations 🎉 for opening your very first pull request in writers-program
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! But it would be nice if you could share a short video by demonstrating that it's now fully responsive, using the developer tools!
Here is the short video demonstrating that it's now fully responsive. keploy.recording.mp4@Swpn0neel Kindly check it now |
Great! Kindly fix the DCO check:
|
Signed-off-by: Shreyash Pawar <[email protected]>
Signed-off-by: Shreyash Pawar <[email protected]>
Signed-off-by: Shreyash Pawar <[email protected]>
@Swpn0neel Thanks. Fixed the DCO check |
KROC leaderboard PR #18 |
Pull Request Template
Description
KROC leaderboard PR #18
The Hero image is aligning with other elements on mobile devices. So used the css queries to solve this issue.
Fixes #8
Type of change
How Has This Been Tested?
Tested the change on the mobile device itself. So, the issue will be solved effectively.
Additional Context (Please include any Screenshots/gifs if relevant)
Visible page on mobile:
Checklist: