Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose "allow_huge" in chi2_shift function #60

Open
adrtsc opened this issue Jul 21, 2024 · 2 comments
Open

Expose "allow_huge" in chi2_shift function #60

adrtsc opened this issue Jul 21, 2024 · 2 comments

Comments

@adrtsc
Copy link
Contributor

adrtsc commented Jul 21, 2024

Hi, I often use chi2_shift to register images and get good results with it. Sometimes, I try to register relatively large images and I get the following error message:

ValueError: Size Error: Arrays will be 3.2G.  Use allow_huge=True to override this exception.

Therefore, I often have to use downscaled versions of the images, which introduces small shifts in the results. Unfortunately, "allow_huge" is not exposed directly from the chi2_shift function. Chi2_shift seems to call on image_registration/fft_tools/correlate2d, which in turn calls convolution/convolve/convolve_fft from astropy.

Would it be reasonable to expose "allow_huge" in image_registration/fft_tools/correlate2d and image_registration/chi2_shifts/chi2_shift?

@keflavich
Copy link
Owner

Yes, that's a good idea. Would you be willing to submit a pull request doing just that?

@adrtsc
Copy link
Contributor Author

adrtsc commented Jul 21, 2024

Great! Sure, I'll submit a PR with the changes next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants