Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance warning message for circular dependency detection in layers #2125

Open
tdhooghe opened this issue Oct 3, 2024 · 1 comment
Open

Comments

@tdhooghe
Copy link

tdhooghe commented Oct 3, 2024

Description

When running Kedro Viz, the following warning rightfully appears when having circular dependencies in the data catalog: WARNING Layers visualisation is disabled as circular dependency detected among layers. This message does not provide sufficient information to diagnose which datasets in the catalog are causing the circular dependency.

Context

Currently, the warning message makes it difficult to identify where the issue exactly. Providing more detailed information about the datasets (or layers) causing the circular dependency would greatly enhance the debugging experience.

Possible Implementation

A very simple fix (which I am very happy to make a PR for), would be to log the CycleError exception and possibly also the layer_dependencies.

Possible Alternatives

A more advanced option would be to even show the exact datasets that are causing the circular dependency, but that might introduce too much complexity (haven't looked at it this deep yet).

Checklist

?

@rashidakanchwala
Copy link
Contributor

This would be very useful. Please do go ahead and submit your PR. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

2 participants