Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to bootstrap 5 #362

Open
blcham opened this issue Oct 3, 2024 · 1 comment · May be fixed by #352
Open

Migrate to bootstrap 5 #362

blcham opened this issue Oct 3, 2024 · 1 comment · May be fixed by #352
Assignees
@palagdan

Comments

@blcham
Copy link
Collaborator

blcham commented Oct 3, 2024 •
edited
Loading

This relates to #352. However, I tried it in Netlify, and it does not work properly:
image

Part of the task should be to go over all forms and check that they look the same (maybe Chromatic is exactly built for that).

A/C:

  • bootstrap is migrated to version > 5
  • all forms within Netlify (master branch vs. PR branch) are compared to make sure that migration worked properly
@blcham blcham mentioned this issue Oct 3, 2024
Closed
@palagdan
Copy link
Collaborator

palagdan commented Oct 8, 2024 •
edited
Loading

@blcham

The issue could be related to the version of React Bootstrap in s-forms. I will try update React Bootstrap first, then Bootstrap itself.

This makes sense since the input field is a React Bootstrap component.

palagdan added a commit that referenced this issue Oct 10, 2024
@palagdan
[#362] Fix input bottom margin
29ffeea
@palagdan palagdan linked a pull request Oct 10, 2024 that will close this issue
Open
palagdan pushed a commit that referenced this issue Oct 16, 2024
@dependabot @palagdan
[#362] Bump bootstrap from 4.6.2 to 5.0.0
c727d5b 
Bumps [bootstrap](https://github.com/twbs/bootstrap) from 4.6.2 to 5.0.0.
- [Release notes](https://github.com/twbs/bootstrap/releases)
- [Commits](twbs/bootstrap@v4.6.2...v5.0.0)

---
updated-dependencies:
- dependency-name: bootstrap
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
palagdan added a commit that referenced this issue Oct 16, 2024
@palagdan
[#362] Bump react bootstrap to 2.10.5
865f6b9
palagdan added a commit that referenced this issue Oct 16, 2024
@palagdan
[#362] Fix input bottom margin
adc5e0c
palagdan added a commit that referenced this issue Oct 16, 2024
@palagdan
[#362] Fix deprecated bootstrap classes
166c674
palagdan added a commit that referenced this issue Oct 16, 2024
@palagdan
[#362] Fix deprecated Accordion usage
4ddca1a
blcham pushed a commit that referenced this issue Nov 4, 2024
@dependabot @blcham
[#362] Bump bootstrap from 4.6.2 to 5.0.0
f90a328 
Bumps [bootstrap](https://github.com/twbs/bootstrap) from 4.6.2 to 5.0.0.
- [Release notes](https://github.com/twbs/bootstrap/releases)
- [Commits](twbs/bootstrap@v4.6.2...v5.0.0)

---
updated-dependencies:
- dependency-name: bootstrap
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
blcham pushed a commit that referenced this issue Nov 4, 2024
@palagdan @blcham
[#362] Bump react bootstrap to 2.10.5
c5b207d
blcham pushed a commit that referenced this issue Nov 4, 2024
@palagdan @blcham
[#362] Fix input bottom margin
6b438e0
blcham pushed a commit that referenced this issue Nov 4, 2024
@palagdan @blcham
[#362] Fix deprecated bootstrap classes
8839517
blcham pushed a commit that referenced this issue Nov 4, 2024
@palagdan @blcham
[#362] Fix deprecated Accordion usage
d8a96c7
blcham pushed a commit that referenced this issue Nov 4, 2024
@dependabot @blcham
[#362] Bump bootstrap from 4.6.2 to 5.0.0
16be5f5 
Bumps [bootstrap](https://github.com/twbs/bootstrap) from 4.6.2 to 5.0.0.
- [Release notes](https://github.com/twbs/bootstrap/releases)
- [Commits](twbs/bootstrap@v4.6.2...v5.0.0)

---
updated-dependencies:
- dependency-name: bootstrap
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
blcham pushed a commit that referenced this issue Nov 4, 2024
@palagdan @blcham
[#362] Bump react bootstrap to 2.10.5
84cb4c2
blcham pushed a commit that referenced this issue Nov 4, 2024
@palagdan @blcham
[#362] Fix input bottom margin
5ac92ff
blcham pushed a commit that referenced this issue Nov 4, 2024
@palagdan @blcham
[#362] Fix deprecated bootstrap classes
7a5a394
blcham pushed a commit that referenced this issue Nov 4, 2024
@palagdan @blcham
[#362] Fix deprecated Accordion usage
af52278
palagdan pushed a commit that referenced this issue Nov 15, 2024
@dependabot @palagdan
[#362] Bump bootstrap from 4.6.2 to 5.0.0
2294c0d 
Bumps [bootstrap](https://github.com/twbs/bootstrap) from 4.6.2 to 5.0.0.
- [Release notes](https://github.com/twbs/bootstrap/releases)
- [Commits](twbs/bootstrap@v4.6.2...v5.0.0)

---
updated-dependencies:
- dependency-name: bootstrap
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
palagdan added a commit that referenced this issue Nov 15, 2024
@palagdan
[#362] Bump react bootstrap to 2.10.5
e515b75
palagdan added a commit that referenced this issue Nov 15, 2024
@palagdan
[#362] Fix input bottom margin
264c521
palagdan added a commit that referenced this issue Nov 15, 2024
@palagdan
[#362] Fix deprecated bootstrap classes
ae7c9ff
palagdan added a commit that referenced this issue Nov 15, 2024
@palagdan
[#362] Fix deprecated Accordion usage
3881883
palagdan added a commit that referenced this issue Nov 15, 2024
@palagdan
[#362] Fix: Selected value of codelist is always underlined
4e0a307
palagdan added a commit that referenced this issue Nov 15, 2024
@palagdan
[#362] Fix: button to submit comments is outside of its pop-up
e17bf31
palagdan added a commit that referenced this issue Nov 15, 2024
@palagdan
[#362] Fix: Align opened/closed section blue color
6561bce
palagdan added a commit that referenced this issue Nov 15, 2024
@palagdan
[#362] Fix: Align bold/not bold fonts
3ec324e
palagdan added a commit that referenced this issue Nov 15, 2024
@palagdan
[#362] Fix: Align bold/not bold fonts
7d0cc2c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@palagdan palagdan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump bootstrap from 4.6.2 to 5.0.0 kbss-cvut/s-forms
2 participants
@blcham @palagdan