Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There are 2 ways how Intl is provided to forms #193

Closed
blcham opened this issue Nov 2, 2022 · 0 comments · Fixed by #340 · May be fixed by #195
Closed

There are 2 ways how Intl is provided to forms #193

blcham opened this issue Nov 2, 2022 · 0 comments · Fixed by #340 · May be fixed by #195
Assignees
@LaChope

Comments

@blcham
Copy link
Collaborator

blcham commented Nov 2, 2022 •
edited
Loading

First way:

  const configurationContext = useContext(ConfigurationContext);

  const intl = configurationContext.options.intl;

Second way:

IntlContextProvider

There should be only one way -- i.e it should be unified.
LaChope added a commit that referenced this issue Nov 8, 2022
@LaChope
[Upd #193] Unified way to provide locale
e485a4f
@LaChope LaChope mentioned this issue Nov 8, 2022
Open
LaChope added a commit that referenced this issue Nov 8, 2022
@LaChope
[Fix #193] Removed IntlProvider from exported modules
d20c315
LaChope added a commit that referenced this issue Nov 8, 2022
@LaChope
[Fix #193] Add intl to comment form story
a069307
@LaChope LaChope mentioned this issue Apr 17, 2024
Merged
@blcham blcham mentioned this issue Apr 22, 2024
Closed
@LaChope LaChope mentioned this issue Apr 22, 2024
Closed
@LaChope LaChope self-assigned this Apr 23, 2024
@LaChope LaChope mentioned this issue Apr 23, 2024
Merged
LaChope added a commit that referenced this issue Apr 23, 2024
@LaChope
[Upd #193] Refactor into functional component to support intl
432bcda
LaChope added a commit that referenced this issue Apr 23, 2024
@LaChope
[Fix #193] Passing intl prop to subquestion + changed wrong import
9d1f385
LaChope added a commit that referenced this issue Apr 23, 2024
@LaChope
[Upd #193] Refactoring messages with new intl provider
9b6a716
LaChope added a commit that referenced this issue Apr 23, 2024
@LaChope
[Fix #193] Mock intl fox question stories
81a7bbb
LaChope added a commit that referenced this issue Apr 23, 2024
@LaChope
[Upd #193] Cleaning unused code
12d482a
LaChope added a commit that referenced this issue Apr 29, 2024
@LaChope
[Upd #193] Refactor into functional component to support intl
8baa158
LaChope added a commit that referenced this issue Apr 29, 2024
@LaChope
[Fix #193] Passing intl prop to subquestion + changed wrong import
d2f1c8c
LaChope added a commit that referenced this issue Apr 29, 2024
@LaChope
[Upd #193] Refactoring messages with new intl provider
c99c47b
LaChope added a commit that referenced this issue Apr 29, 2024
@LaChope
[Fix #193] Mock intl fox question stories
5e12892
LaChope added a commit that referenced this issue Apr 29, 2024
@LaChope
[Upd #193] Cleaning unused code
f2d03c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LaChope LaChope

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Harmonize way to provide intl kbss-cvut/s-forms
Unify way to provide locale kbss-cvut/s-forms
2 participants
@blcham @LaChope