Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Profile #78

Open
RobLoach opened this issue Apr 17, 2020 · 4 comments
Open

Install Profile #78

RobLoach opened this issue Apr 17, 2020 · 4 comments
Assignees

Comments

@RobLoach
Copy link

No description provided.

@RobLoach
Copy link
Author

Rather than a Install Profile, may be better to use a set of default configs for each component. Then you can pick and choose features.

@mikemccaffrey
Copy link

I've gone ahead and created the install profile. All it basically does right now is install the modules that have been included in composer.json, and also a sane selection of core modules.

Anya worries that we might have maintenance issues when installing a site using a custom install profile. I've certainly seen that cause problems for teams in the past, but they all seemed to be trying to use them for more complicated processes than just as an initial install. We should research if that actually does cause a problem of some sort, as I was unable to find anything with a cursory search.

We also need to figure out how to set some config variables on install, but with install profiles you are limited to either providing a config directory or using a profile.install file. We should figure out which is the most maintainable way to make a limited number of config changes without including too much cruft or dealing with schema mismatches in the future.

@mikemccaffrey mikemccaffrey self-assigned this May 17, 2020
@RobLoach
Copy link
Author

We can have the Install Profile provide the absolute basics, and then shift the optional default configs where applicable.

@mikemccaffrey
Copy link

I would like the install profile to make some common configuration changes, just so we can be sure that they are not missed when importing any optional configs files.

My preference would be to make the changes programmatically, so that we can have a laser-focus on just the attributes that we are looking to change, along with properly commenting the reasons that we are making those settings changes.

Here is what it looks like to have an install function setting configuration for the install profile:
https://github.com/kalamuna/drupal-project/blob/master/assets/install_profile.install

The config files concern me because they seem a bit more difficult to maintain over the long term, since they would need to be exported regularly to avoid problems with any schema changes that are introduced as modules are updated. And that exporting process still requires manual stripping of UUIDS and hashes that are site-specific, which seems like a time-intensive process that could be prone to errors.

enotick added a commit that referenced this issue May 20, 2020
* origin/master:
  Don't send email on non-live environments. (#80)
  Add warning that settings.php will be overwritten. (#85)
  Add install file to the profile for config changes. (#78)
  Add devel and stage_file_proxy as dev requirements.
  Update readme after new contrib and install profile.
  Add install profile for installing common modules.
  Add contrib modules most commonly used.
  Update versions of required packages in composer.json.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants