Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsx-a11y/iframe-has-title: title should not be required for hidden frames #946

Open
LosYear opened this issue Jul 18, 2023 · 4 comments
Open
Assignees

Comments

@LosYear
Copy link

LosYear commented Jul 18, 2023

Hey!

Let's consider a case when we have some technical iframe on the page (e.g. collect some user actions). According to a11y rules we will add aria-hidden=true to hide it from assistive techs and tabIndex=-1 to exclude it from keyboard access.

In this case eslint plugin still requires title attribute but it seems to be redundant.

Screenshot 2023-07-18 at 16 13 22

Please let me know, what do you think about this case :)

@LosYear
Copy link
Author

LosYear commented Jul 18, 2023

I'm ready to submit a PR to fix it if you agree that it is undesired behaviour

@ljharb
Copy link
Member

ljharb commented Jul 18, 2023

Why would aria-hidden mean a user wouldn’t be able to hover their mouse cursor over it?

@LosYear
Copy link
Author

LosYear commented Jul 19, 2023

Why would aria-hidden mean a user wouldn’t be able to hover their mouse cursor over it?

Good question, btw. Since aria-hidden means that we do not want iframe to be interactable for screen readers, I don’t think it’s a good idea to force any accessibility attributes on it. Don’t you think so?

Title for an element that is hidden from assistive techs seems to be redundant

According to MDN, https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe#accessibility_concerns:

People navigating with assistive technology such as a screen reader can use the title attribute on an <iframe> to label its content

Negative tabIndex or inert is required for consistency because:

aria-hidden="true" should not be used on elements that can receive focus. Additionally, since this attribute is inherited by an element's children, it should not be added onto the parent or ancestor of a focusable element

@ljharb
Copy link
Member

ljharb commented Jul 19, 2023

Things with a title pop up a tooltip when you hover over them, but maybe that's not the case if they're aria-hidden, i'd have to test it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants