From 41aa51f6b1545c0d9997c20e3c96f7b7659a5b63 Mon Sep 17 00:00:00 2001 From: Joe Fearnley Date: Thu, 14 Jul 2016 11:43:02 -0400 Subject: [PATCH 1/3] Inializing arrowSize variable in setElementPosition function --- dist/notify.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dist/notify.js b/dist/notify.js index 3971640..59fab3b 100644 --- a/dist/notify.js +++ b/dist/notify.js @@ -392,7 +392,8 @@ incr(css, pos, margin); } } - gap = Math.max(0, this.options.gap - (this.options.arrowShow ? arrowSize : 0)); + arrowSize = (this.options.arrowShow ? this.options.arrowSize : 0); + gap = Math.max(0, this.options.gap - arrowSize); incr(css, oppFull, gap); if (!this.options.arrowShow) { this.arrow.hide(); From 4aab096aa785d1f333cde2dc3e6db4664279f4ed Mon Sep 17 00:00:00 2001 From: Joe Fearnley Date: Thu, 14 Jul 2016 11:44:29 -0400 Subject: [PATCH 2/3] fixing spacing --- dist/notify.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dist/notify.js b/dist/notify.js index 59fab3b..877ce84 100644 --- a/dist/notify.js +++ b/dist/notify.js @@ -393,7 +393,7 @@ } } arrowSize = (this.options.arrowShow ? this.options.arrowSize : 0); - gap = Math.max(0, this.options.gap - arrowSize); + gap = Math.max(0, this.options.gap - arrowSize); incr(css, oppFull, gap); if (!this.options.arrowShow) { this.arrow.hide(); From a04b34f87c3e3cd44553edc83e421f9fd2f96cfb Mon Sep 17 00:00:00 2001 From: Joe Fearnley Date: Thu, 14 Jul 2016 11:52:29 -0400 Subject: [PATCH 3/3] removing initilization of the arrowSize at a later point in the code --- dist/notify.js | 1 - 1 file changed, 1 deletion(-) diff --git a/dist/notify.js b/dist/notify.js index 877ce84..b4e7566 100644 --- a/dist/notify.js +++ b/dist/notify.js @@ -398,7 +398,6 @@ if (!this.options.arrowShow) { this.arrow.hide(); } else { - arrowSize = this.options.arrowSize; arrowCss = $.extend({}, css); arrowColor = this.userContainer.css("border-color") || this.userContainer.css("border-top-color") || this.userContainer.css("background-color") || "white"; for (k = 0, len1 = mainPositions.length; k < len1; k++) {