Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add option to present a "squash mode" view of multiple stacked commits #5

Open
rmloveland opened this issue Sep 21, 2018 · 0 comments

Comments

@rmloveland
Copy link

Prompted by #4, which included this explanation from @jordanlewis :

re presents a review as one set of diffs per commit. If you scroll through that file, you can see that all of the diffs are eventually available for each file - they're just not squashed for you. This allows you to leave comments on diffs from multiple different commits, which facilitates a mode of PR-review where people are trying to PR a sequence of fully-baked commits at once.

The current mode of operation of re isn't set up to facilitate review of PRs that have multiple "fixup" commits stacked onto each other - for that you do want a squash mode of review, which I haven't implemented yet.

Proposed CLI interface (just something to get the discussion started; not sure what's best really):

usage: re [-p owner/repo] [-resume file] [-squash] pr-number

  -squash
        Present the sum of changes to the user as a single diff
  -p string
    	GitHub owner/repo name (default "cockroachdb/cockroach")
   ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant