Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize color besides colour #56

Open
bersbersbers opened this issue Aug 21, 2020 · 1 comment
Open

Recognize color besides colour #56

bersbersbers opened this issue Aug 21, 2020 · 1 comment

Comments

@bersbersbers
Copy link

library(ggplot2)
df = data.frame(my_x=1, my_y=2, my_col=3)
p <- ggplot(df, aes(x=my_x, y=my_y, color=my_col)) + geom_point()
print(p + labs(colour = "works, too"))
print(p + labs(color = "works"))
print(p + ggeasy::easy_labs(colour = "works, yeah"))
print(p + ggeasy::easy_labs(color = "does not work"))

Ergo, ggeasy::easy_labs does not recognize color, while ggplot2::labs does.

@jonocarroll
Copy link
Owner

Good idea! ggplot2 does an internal lookup of aes alternatives and we can borrow that logic to be consistent.

I can't guarantee a timeline, so if you're interested you're welcome to have a go at implementing this change in a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Refinement
Development

No branches or pull requests

2 participants