Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting y axis text would be awesome #43

Open
smach opened this issue Mar 19, 2020 · 5 comments
Open

Formatting y axis text would be awesome #43

smach opened this issue Mar 19, 2020 · 5 comments

Comments

@smach
Copy link

smach commented Mar 19, 2020

Just a thought: Adding comma, dollar, or percent formatting with ggeasy would be a nice feature!

@jonocarroll
Copy link
Owner

Hi, thanks for the suggestion! Do you have an example of how to do this (the hard way) that we could target?

@jonocarroll
Copy link
Owner

If you're interested in contributing, the last PR might serve as a good guide of what is required: https://github.com/jonocarroll/ggeasy/pull/39/files

@smach
Copy link
Author

smach commented Mar 20, 2020

It's scales:: scale_y_continuous(labels = comma) which isn't all that much code, just difficult to remember. And as far as I know, still requires the scales package.

I'll take a look at the code, but I'm not overly optimistic about feeling confident enough to code it myself :-)

@yonicd
Copy link
Collaborator

yonicd commented Mar 20, 2020

@jonocarroll maybe we can add a helper fn that will set up the proper code that is needed to contribute to the package. Or at least a checklist of things that need to be done in contributing.md with an example people can follow.

We did this in remedy and it gave us a common language we could converse with other users.

@jonocarroll
Copy link
Owner

@smach all good - feel free to have a crack at it if you like, no pressure, I'll help if you get stuck.

@yonicd great idea, let's work something up. I'd also like to generalise the teach code so it's easier to implement for new functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants