Fedora 39 Build Issue

[cohoe]

Documenting this here in hope that someone (including the rubber ducks) can help me wrap my brain around what has happened here.

Commit at 896c47a was building just fine on Fedora 36 (glibc 2.35 + Swift 5.8.0). When the same commit is built on Fedora 39 (glibc 2.38 + Swift 5.8.0) it blows up with complication errors:

/home/grant/Projects/priv/swiftarr/.build/checkouts/swift-log/Sources/Logging/Logging.swift:1392:64: error: value of optional type 'UnsafeMutablePointer<tm>?' must be unwrapped to a value of type 'UnsafeMutablePointer<tm>'
        strftime(&buffer, buffer.count, "%Y-%m-%dT%H:%M:%S%z", localTime)

Description and "workaround" given in apple/swift-log#278 (JCWasmx86/swift-log@332ed31)
We then hit:

/home/grant/Projects/priv/swiftarr/.build/checkouts/swift-nio-ssl/Sources/NIOSSL/PosixPort.swift:42:64: error: cannot convert value of type '(UnsafeMutablePointer<FILE>) -> Int32' (aka '(UnsafeMutablePointer<_IO_FILE>) -> Int32') to specified type '@convention(c) (FILEPointer?) -> CInt' (aka '@convention(c) (Optional<UnsafeMutablePointer<_IO_FILE>>) -> Int32')
private let sysFclose: @convention(c) (FILEPointer?) -> CInt = fclose

Description and "workaround" given in apple/swift-nio-ssl#429
Finally we hit our own code issues:

/home/grant/Projects/priv/swiftarr/Sources/swiftarr/Image/Image.swift:359:18: error: value of optional type 'UnsafeMutablePointer<FILE>?' (aka 'Optional<UnsafeMutablePointer<_IO_FILE>>') must be unwrapped to a value of type 'UnsafeMutablePointer<FILE>' (aka 'UnsafeMutablePointer<_IO_FILE>')
...
/home/grant/Projects/priv/swiftarr/Sources/swiftarr/Image/Image.swift:393:18: error: value of optional type 'UnsafeMutablePointer<FILE>?' (aka 'Optional<UnsafeMutablePointer<_IO_FILE>>') must be unwrapped to a value of type 'UnsafeMutablePointer<FILE>' (aka 'UnsafeMutablePointer<_IO_FILE>')

Both of which can be fixed by force-unwrapping the various file handles in the respective calls.

It seems that all of this stems from some kind of change in the way Swift interacts with newer (>2.35) glibc.

[cohoe]

These issues are fixed in latest swift-log and swift-nio-ssl which will get updated in my next PR.