Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test suite should test json files #9

Open
ocehugo opened this issue Sep 30, 2015 · 1 comment
Open

test suite should test json files #9

ocehugo opened this issue Sep 30, 2015 · 1 comment

Comments

@ocehugo
Copy link

ocehugo commented Sep 30, 2015

Currently the run_tests.sh script is not testing the output of ncdump-json, just if the command should run.

I also believe that more cdls can be add to the testing suite (unidata has a lot of them). I think the best way to handle this is a list of the file locations (or http locations) so you could load the file, run ncdump-json in all entries, and test a json reader on the output.

Cheers

@jllodra
Copy link
Owner

jllodra commented Oct 2, 2015

Hi @ocehugo,

tests were done, but I switched to python json.tool, added a new unidata example file, and improved the tests/README.md to make things clear.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants