You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
pascalgrimaud
changed the title
Allow the cloud version to create project and submit PR
Allow the cloud instance to create project and submit PR
Aug 19, 2024
I'm currently working on this issue and decided to start with a small feature on the backend:
Enable generating a token using GitHub login and return that token.
As I was developing, I noticed that the spring-boot-oauth2 module in jhipster-lite already has a pretty robust implementation for OAuth2 authentication.
However, the goal with GitHub here is just to fetch repository information and make changes on GitHub. The aim isn't to enforce a security layer across the entire jhipster-lite app, where access to certain endpoints depends on whether you're logged in with GitHub or not.
So, I'm moving forward without using the spring-boot-oauth2 module and instead creating a github module in src/main/java/tech/jhipster/lite/shared/github.
What do you all think? Does my approach make sense, or should I reconsider using the spring-boot-oauth2 module?
This ticket is a really big feature.
I'm not sure we should implement it now, we should discuss about it first and estimate the real value to have it.
So for now we should focus on other small features...
This ticket is a really big feature. I'm not sure we should implement it now, we should discuss about it first and estimate the real value to have it.
@pascalgrimaud : I agree 100% that it is indeed a big feature. I haven't created any pull requests because I took a step back and I am deeply studying OAuth2 while developing a prototype to demonstrate the possible workflow I am considering implementing. This way, we can talk about whether it's worth pursuing or not.
So for now we should focus on other small features...
It's a global ticket here, which must be splitted into smaller ones
The idea is:
It's similar to what JHipster Online provides, we should keep the idea, but not the code
The text was updated successfully, but these errors were encountered: