You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
connectFTP doesn't close sockets on connection failure, only throwing an exception. I'm not sure whether it would be more appropriate to fix in connectFTP itself or in MissingH's connectTCP/connectTCPAddr (since it's not clear what is the intended behaviour of connectTCP), but in programs using connectFTP there's no socket to close, so apparently should be fixed in one of those.
The text was updated successfully, but these errors were encountered:
Although it looks like connectTCPAddr should handle that, since leaking file descriptors from it doesn't seem like a sensible behaviour. Submitted a PR there, and perhaps ftphs should just increase the required MissingH version once/if it will be fixed there.
connectFTP
doesn't close sockets on connection failure, only throwing an exception. I'm not sure whether it would be more appropriate to fix inconnectFTP
itself or in MissingH'sconnectTCP
/connectTCPAddr
(since it's not clear what is the intended behaviour ofconnectTCP
), but in programs usingconnectFTP
there's no socket to close, so apparently should be fixed in one of those.The text was updated successfully, but these errors were encountered: