Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why does getbinary return a String? #19

Open
Xandaros opened this issue Jul 25, 2017 · 1 comment
Open

Why does getbinary return a String? #19

Xandaros opened this issue Jul 25, 2017 · 1 comment

Comments

@Xandaros
Copy link

Since we are dealing with binary data, why is it not returning a ByteString?
@jgoerzen
Copy link
Owner

The simple answer is that ByteString didn't exist when ftphs was written. A patch would be welcome.

Xandaros added a commit to Xandaros/ftphs that referenced this issue Jul 27, 2017
@Xandaros
Make getbinary return ByteString
fb563ba 
Closes jgoerzen#19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jgoerzen @Xandaros