Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Global Effect: Output Ceiling #37

Open
Phazmaonline opened this issue Jul 27, 2022 · 5 comments
Open

[Feature Request] Global Effect: Output Ceiling #37

Phazmaonline opened this issue Jul 27, 2022 · 5 comments

Comments

@Phazmaonline
Copy link

While playing with multiband distortion I have noticed that it is easy to get a pretty high peak level on the output. I think it would be nice if we had an option to link the global output level to some sort of safety limiter or clipper ceiling, meaning we will never get higher levels than what we set as Output dB.

@jerryuhoo
Copy link
Owner

Like adding a limiter in case of the level is over 0db? That sounds doable.

@Phazmaonline
Copy link
Author

Yes something like that. I would put it as last step in the signal chain before the global output level knob. (So that when i set the output level to -6dB for example, I know that the audio coming out of the plugin will never be higher than -6dB).

This was referenced Jul 28, 2022
@jerryuhoo
Copy link
Owner

I just released v1.0.0, feel free to reopen this issue if you have any suggestions or questions.

@Phazmaonline
Copy link
Author

Thanks for adding the limiter. Something seems to not work as expected though. There is always an initial transient that slips through and goes up to 0dB, even if the threshold is lower. And after that initial part the signal is limited to a level which is lower than the chosen threshold. I recorded a video that shows it - as you can see with this particular sound the output is always 2.5dB lower than the threshold.

Limiter.Fire.mov

@jerryuhoo
Copy link
Owner

jerryuhoo commented Jul 31, 2022

Dang! I used the juce::dsp::limiter and it seems not the original limiter that I thought. It has auto make-up so it is louder than normal. Do you think it is good to use a compressor in the global panel and you can change the ratio to be either a compressor or a limiter (when the ratio is larger than 20:1)?

Edit: seems like I have to implement a limiter by myself. Although the ratio is very large, the output level is still large than 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants