-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make include_nodata argument available for built-in operations #147
Comments
Not sure what the effort is, so difficult to judge the cost/benefits, but at least it is quite a bit cleaner. In quite some cases it might even be impossible to use the work around. Finding a values that is surely not being used next to the actual nodata value will at least be a fuss, and in some cases it will even be impossible without actually recoding the data, or using a fake value if that works? E.g. data that has been encoded to a byte, often all values are "taken", so choosing a |
I was thinking of "count", where it doesn't matter if the value is "taken." But I guess it's also useful for "unique" and "frac".
I would expect |
True... clear names (for everyone) are sometimes difficult to find. Once explained it does make sense... I also misunderstood how it worked, now I understand. Adding a keyword will be clearer, but I suppose just documenting it properly with some examples should be ok as well? Keywords for many different use cases where you could use it but actually mapping to the same thing might make the API even less understandable in end, even though for this one case this is not the case yet? |
Would make
count(include_nodata=true)
available as a more legible alternative to e.g.count(default_value=0)
. Not sure if it's worth it.The text was updated successfully, but these errors were encountered: