Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Rewrite Thrown exceptions #127

Open
kwek20 opened this issue Oct 28, 2018 · 3 comments
Open

Rewrite Thrown exceptions #127

kwek20 opened this issue Oct 28, 2018 · 3 comments

Comments

@kwek20
Copy link
Contributor

kwek20 commented Oct 28, 2018

Issue

Currently most exceptions are thrown into one big pile called ArgumentException.
We should specify between derivatives of RuntimeException for input parameters, and specific derivatives of ArgumentException for node errors.

Motivation

You should only handle errors you are able to handle. Therefor you should only catch errors you can process. By having one exception contain all the errors, we are prone to mistakes

@GalRogozinski
Copy link

@GalRogozinski
Copy link

We need to see if we can have Jota throw different exception depending on the cause of the error.
I am especially interested on the case of finding TimeoutExceptions on the server side.

@ezienecker
Copy link
Contributor

Make sure to refactor the HttpConnector wrapException method and use this approach instead: square/retrofit#1497

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants