Skip to content
This repository has been archived by the owner on Dec 2, 2023. It is now read-only.

Audio Level Detection #130

Closed
tarrencev opened this issue Apr 20, 2020 · 4 comments
Closed

Audio Level Detection #130

tarrencev opened this issue Apr 20, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@tarrencev
Copy link
Contributor

I am interesting in adding audio level detection for stream prioritization. I'd like to use RTP header extensions to extract this information according to https://tools.ietf.org/html/rfc6464. I would like to implement this as a router extension. We can handle toggling video quality based on the active speaker.

I'm working on understanding what is necessary to add this functionality. It doesnt seem that pion parses these headers today (looking at https://github.com/pion/rtp/). But i do see AudioLevel in the stats package here:
https://github.com/pion/webrtc/blob/93261960b1c10359cfeef337a0710c4b0ce3c8a6/stats.go#L704

Is my understanding correct that we need to first implement the header parsing in the rtp package or is it possible to use the existing stats package? Any other insights appreciated too :)

@adwpc
Copy link
Collaborator

adwpc commented May 2, 2020

Yep, maybe you should add this feature in pion first

@adwpc adwpc added the enhancement New feature or request label May 2, 2020
@tarrencev
Copy link
Contributor Author

Added extension support in pion/rtp#55

@grahamking
Copy link

These two PRs make ion-sfu negotiate that extension:

@adwpc
Copy link
Collaborator

adwpc commented May 1, 2021

will support in #546

@adwpc adwpc closed this as completed May 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants