Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

funder: Custom funder should support free text entry #293

Open
tmorrell opened this issue Feb 9, 2024 · 0 comments
Open

funder: Custom funder should support free text entry #293

tmorrell opened this issue Feb 9, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@tmorrell
Copy link
Contributor

tmorrell commented Feb 9, 2024

Package version (if known): v9-v12

Describe the bug

In the API you can provide either the name OR the id for a funder https://inveniordm.docs.cern.ch/reference/metadata/#funding-references-0-n. However, the deposit form doesn't have an "Add ..." option show up to allow you to add a funder that is not in the vocabulary. This makes it impossible for users to add funders that are not yet in ROR.

Steps to Reproduce

  1. Go to the deposit form
  2. Click on Funding, Add Custom
  3. Type in a Funder that doesn't exist in ROR (Caltech Library).
  4. There is no option to add the funder

Additional context

In theory, this should be as simple as removing false from

. However this doesn't work because everything typed (C, Ca, Cal,...) gets added as an "Add' suggestion. The allowAdditions behavior works correctly on the affiliation and subjects fields, but there are enough differences between the implementations that a refactor might be needed.
Screenshot 2024-02-09 at 3 17 09 PM

@tmorrell tmorrell added the bug Something isn't working label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant