api: proper GIF operations #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you rebase? |
egabancho
approved these changes
Apr 11, 2017
drjova
reviewed
Apr 13, 2017
flask_iiif/api.py
Outdated
| self.image.save(image_buffer, cleaned_image_format, quality=quality) | ||
| save_kwargs = dict(quality=quality) | ||
|
|
||
| if self.image.format == 'GIF': |
There was a problem hiding this comment.
just this one, are we sure is always capital GIF?
There was a problem hiding this comment.
I will capitalize, to be 100% sure.
There was a problem hiding this comment.
drjova
approved these changes
Apr 13, 2017
|
@egabancho @drjova Please do not merge yet, as I will update it with a solution for the rest of the operations. |
|
@drjova ping |
* Adds custom behaviour for operations on GIF images, as `PIL.Image` operations do not work out-of-the-box (closes #41). * Additionally passes `save_all=True` as a keyword arguement on `PIL.Image.save` when serving the file over HTTP. * Bumps `Pillow`'s version to 3.4, where they introduce functionality for creating GIF images out of individual frame images. * Updates tests to cover GIF operations. Signed-off-by: Orestis Melkonian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds custom behaviour for operations on GIF images, as
PIL.Imageoperations do not work out-of-the-box (closes Operations on GIF images do not preserve its frames. #41).
Additionally passes
save_all=Trueas a keyword arguement onPIL.Image.savewhen serving the file over HTTP.Bumps
Pillow's version to 3.4, where they introduce functionalityfor creating GIF images out of individual frame images.
Updates tests to cover GIF operations.
Signed-off-by: Orestis Melkonian [email protected]