Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial level design questions and disucssions #8

Open
girishg4t opened this issue Apr 8, 2021 · 1 comment
Open

Initial level design questions and disucssions #8

girishg4t opened this issue Apr 8, 2021 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@girishg4t
Copy link
Contributor

girishg4t commented Apr 8, 2021

  1. when we do krius install Prometheus, which chart we need to use ?
    We need to use Prometheus Operator also we need to use helm sdk to install the chart etc (not the direct command) ?
    https://infracloud.slack.com/archives/C01MS8GSG03/p1617870417010200

  2. When we install new chart should i take release name as random number with krius ?
    If release name and namespace is passed by flag like below
    --name=my-release
    --namespace=demo
    else generate it

  3. do we need to give support for values.yaml as well ?
    Not for Prometheus operator

  4. how to we install sidecar or receiver through thanos from which chart ?
    i. As per discussion with Shaunak and other's when we do krius install thanos sidecar we need to use https://github.com/prometheus-community/helm-charts/blob/main/charts/kube-prometheus-stack/templates/prometheus/prometheus.yaml#L262 to enable the sidecar
    ii. when we do krius install thanos receiver then we have to use https://github.com/bitnami/charts/tree/master/bitnami/thanos
    https://infracloud.slack.com/archives/C01MS8GSG03/p1617870417010200
    Note: to install receiver objstore configuration need to be installed

Below questions need to be confirmed

  1. What we need to do when use give command krius configure objstore , this is because to install receiver we need to use objstore , so will it be in sequence or receiver install will install objstore automatically, also values.yaml need to be passed

  2. how we will do helm repo add for eg. when we do "helm install [RELEASE_NAME] prometheus-community/kube-prometheus-stack"

  3. How we will be adding sidecar to the existing prometheus component if the release name is dynamically generated

@Dhru1Tanna
Copy link

Adding to it,

  • We will also have to register a command to list the kirus releases (non-profile) which the user can use to grab the release name.
    Something like krius list releases or krius list proms

  • The release names needs to be passed for example, when the user wants to install thanos sidecar.

@YachikaRalhan YachikaRalhan added the documentation Improvements or additions to documentation label Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants