Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Think about whether to make the interior value optional in TracePair #241

Open
majosm opened this issue Mar 21, 2022 · 0 comments
Open

Think about whether to make the interior value optional in TracePair #241

majosm opened this issue Mar 21, 2022 · 0 comments

Comments

@majosm
Copy link
Collaborator

majosm commented Mar 21, 2022

In certain use cases, only the exterior value is needed from a TracePair. For example: in one possible implementation of a multi-volume simulation in MIRGE-Com, the simulation driver would call inter_volume_trace_pairs (from #236) outside of the subdomain operator calls, feed the exterior values from the result into a set of boundary condition constructors, and discard the interior values. These boundary conditions would then be applied inside the individual operator calls (and at that time they would then be supplied interior values by the operator).

This issue is a reminder to think about whether the interior value should be made optional in TracePair, so that inter_volume_trace_pairs, etc., can be configured to only return the exterior values, or whether it should be left alone and we should just depend on lazy to eliminate any performance penalty.

cc @inducer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant