Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cross_rank_trace_pairs implicitly projects from the volume #206

Open
inducer opened this issue Jan 11, 2022 · 2 comments
Open

cross_rank_trace_pairs implicitly projects from the volume #206

inducer opened this issue Jan 11, 2022 · 2 comments

Comments

@inducer
Copy link
Owner

inducer commented Jan 11, 2022

That makes it impossible to communicate quantities that are already on the boundary. No good reason for that restriction.

cc @matthiasdiener @majosm @MTCam @thomasgibson

@MTCam
Copy link
Collaborator

MTCam commented Jan 11, 2022

I guess we should take care about changing this behavior on which MIRGECom depends (more-or-less). Less now since we almost exclusively use interior_trace_pairs to get data on the partition boundaries. I might argue for leaving the current behavior alone and adding a separate facility for communicating data that is already on the boundary, as that seems like a less-needed functionality (i.e. from the MIRGECom perspective).

@inducer
Copy link
Owner Author

inducer commented Jan 11, 2022

I might argue for leaving the current behavior alone and adding a separate facility for communicating data that is already on the boundary, as that seems like a less-needed functionality (i.e. from the MIRGECom perspective).

I completely agree. I wasn't suggesting we break backward compatibility, and I wasn't sure of a use case. It just seemed odd that things were being done that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants