Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create end-to-end tests for scheduled backups #181

Open
wallrj opened this issue Mar 5, 2020 · 0 comments
Open

Create end-to-end tests for scheduled backups #181

wallrj opened this issue Mar 5, 2020 · 0 comments

Comments

@wallrj
Copy link
Contributor

wallrj commented Mar 5, 2020

In #165 I found that the scheduled backup mechanism was broken.
The kubebuilder tests use a fake cronhandler which executes jobs immediately.
In the actual implementation, we had forgotten to start the cron handler and we'd forgotten to create RBAC roles to allow the etcdbackupschedule_controller to create etcdbackup resources.

@wallrj wallrj mentioned this issue Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant