Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run restoreagent as root #139

Open
JamesLaverack opened this issue Jan 21, 2020 · 2 comments
Open

Don't run restoreagent as root #139

JamesLaverack opened this issue Jan 21, 2020 · 2 comments

Comments

@JamesLaverack
Copy link
Contributor

Currently the restoreagent executes as root in a pod. The etcd pod, which runs as root, expects the data directory to be owned by root:root. So the restore agent must be able to write to the PVC as root:root.

Ideally Kubernetes features such as fsGroup should be used to remove this requirement and run the restore agent as nonroot.

@ghost
Copy link

ghost commented Nov 3, 2021

We have the same issue when we try to run the operator - not only the restoreagent - as a non-root user, we can not set the security context (runAsUser,fsGroup) for the replicaSet.

I had a quick at the source code and seems like it's doable to implement it.

@JamesLaverack as you are part of improbable-eng Are there plans at improbable-eng to correct it?
I also have the feeling that this project is abandoned (no replies to issues/PR requests)

@JamesLaverack
Copy link
Contributor Author

Hi @stafwag-idirect. To clarify, I'm not a member of Improbable but I am one of the authors of this operator. I can't speak to Improbable's ongoing intent. @adamhosier and @cheahjs might have more insight there.

We don't have any particular SLA on responding to comments and pull requests, but I can take a look at this when I get chance.

I agree that it should be pretty straightforward to implement though. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant