You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are two parameter issues with valkyrie_ros_api.launch:
as discussed with @dljsjr, /use_sim_time is hardcoded to true, which can cause hard-to-debug time issues (t not ticking in RemoteValkyrieVisualizer, causing calibration to never finish, boxStep.py issues because rate.sleep() sleeps forever).
valkyrie_A.urdf is hardcoded.
For 1, should /use_sim_time just always be set to false? It looks like this launch file is never meant to be run in simulation.
For 2, what is the right place to get the appropriate URDF file?
The text was updated successfully, but these errors were encountered:
The URDF model shouldn't really matter as long as it's not the sim model, as the physical properties are the same between A/B/C/D; the only differences are the custom tags that encode the TurboDriver information which doesn't impact the Robot State Publisher.. URDF's assume a working installation of Val Description from NASA.
The Sim Time parameter should probably default to false and we should either provide two separate launch files (one for real robot and one for sim) or make it clear that users should set that parameter when using SCS/Gazebo.
There are two parameter issues with
valkyrie_ros_api.launch
:/use_sim_time
is hardcoded totrue
, which can cause hard-to-debug time issues (t
not ticking inRemoteValkyrieVisualizer
, causing calibration to never finish,boxStep.py
issues becauserate.sleep()
sleeps forever).valkyrie_A.urdf
is hardcoded.For 1, should
/use_sim_time
just always be set tofalse
? It looks like this launch file is never meant to be run in simulation.For 2, what is the right place to get the appropriate URDF file?
The text was updated successfully, but these errors were encountered: