Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

valkyrie_ros_api.launch parameter issues #16

Open
tkoolen opened this issue Aug 28, 2017 · 1 comment
Open

valkyrie_ros_api.launch parameter issues #16

tkoolen opened this issue Aug 28, 2017 · 1 comment

Comments

@tkoolen
Copy link

tkoolen commented Aug 28, 2017

There are two parameter issues with valkyrie_ros_api.launch:

  1. as discussed with @dljsjr, /use_sim_time is hardcoded to true, which can cause hard-to-debug time issues (t not ticking in RemoteValkyrieVisualizer, causing calibration to never finish, boxStep.py issues because rate.sleep() sleeps forever).
  2. valkyrie_A.urdf is hardcoded.

For 1, should /use_sim_time just always be set to false? It looks like this launch file is never meant to be run in simulation.

For 2, what is the right place to get the appropriate URDF file?

@dljsjr
Copy link
Contributor

dljsjr commented Aug 31, 2017

The URDF model shouldn't really matter as long as it's not the sim model, as the physical properties are the same between A/B/C/D; the only differences are the custom tags that encode the TurboDriver information which doesn't impact the Robot State Publisher.. URDF's assume a working installation of Val Description from NASA.

The Sim Time parameter should probably default to false and we should either provide two separate launch files (one for real robot and one for sim) or make it clear that users should set that parameter when using SCS/Gazebo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants