Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multi-system to physics classes #29019

Open
GiudGiud opened this issue Nov 6, 2024 · 2 comments · May be fixed by #29021
Open

Add support for multi-system to physics classes #29019

GiudGiud opened this issue Nov 6, 2024 · 2 comments · May be fixed by #29021
Labels
C: Framework T: task An enhancement to the software.

Comments

@GiudGiud
Copy link
Contributor

GiudGiud commented Nov 6, 2024

Motivation

It is known that equations that are not two-way coupled, (either uncoupled, or one-way coupled) are solved much more efficiently using a multi-system approach than a single system approach

Design

Add logic to enable multi-system coupling in the action

Impact

Faster solves
More flexibility
@GiudGiud GiudGiud added C: Framework T: task An enhancement to the software. labels Nov 6, 2024
GiudGiud added a commit to GiudGiud/moose that referenced this issue Nov 6, 2024
@GiudGiud
Add support for multi-system at the Physics base class refs idaholab#…
fd18968 
…8780 idaholab#29019
GiudGiud added a commit to GiudGiud/moose that referenced this issue Nov 6, 2024
@GiudGiud
Add support for multi-system at the Physics base class refs idaholab#…
0069f38 
…8780 idaholab#29019
GiudGiud added a commit to GiudGiud/moose that referenced this issue Nov 6, 2024
@GiudGiud
Add support for multi-system at the Physics base class refs idaholab#…
74118ea 
…8780 idaholab#29019
@lindsayad
Copy link
Member

I'd also be curious how a multiplicative field-split does for these one-way coupling cases

@GiudGiud
Copy link
Contributor Author

GiudGiud commented Nov 6, 2024

For sure. It could perform just as well. It's just conceptually easier to do multi-system

@GiudGiud GiudGiud linked a pull request Nov 7, 2024 that will close this issue
Open
GiudGiud added a commit to GiudGiud/moose that referenced this issue Nov 12, 2024
@GiudGiud
Add support for multi-system at the Physics base class refs idaholab#…
9342e36 
…8780 idaholab#29019
GiudGiud added a commit to GiudGiud/moose that referenced this issue Nov 14, 2024
@GiudGiud
Add support for multi-system at the Physics base class refs idaholab#…
af40fae 
…8780 idaholab#29019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Framework T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add multi-system to FEProblemSolve and deploy on Physics syntax GiudGiud/moose
2 participants
@lindsayad @GiudGiud