Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve handling of edge cases related to source position at boundary where no/little MC is vailable. #70

Open
HansN87 opened this issue Jul 21, 2020 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@HansN87
Copy link
Contributor

HansN87 commented Jul 21, 2020

Injecting a source at -5.7 deg (at the edge of Northern Tracks even selection) yields the following non-descriptive error message:

[...]
File "/data/user/hmniederhausen/software/skyllh_v003p03_v1/skyllh/skyllh/core/parameters.py", line 1256, in _calc_floatD_and_intD
','.join(str(v) for v in value[np.invert(m)])))
ValueError: The following values are outside the range of the parameter grid "gamma": nan

A better way of handling this would be to require each analysis to provide a "safe" range / bounds for the source declination.

@HansN87 HansN87 added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 21, 2020
@chiarabellenghi
Copy link
Member

Funny thing, I saw this very same non-descriptive error when using the publicdata_ps branch. But with public data, we don't have any specific declination constraints, and I was injecting right at the horizon (-0.01 deg).

The issue might be related to some bin edge issues.

@chiarabellenghi chiarabellenghi self-assigned this Sep 19, 2022
@martwo
Copy link
Collaborator

martwo commented Oct 10, 2023

For the IceCube internal KDE point-source analysis this issue was fixed with PR #182

For the public PS data this might still be an issue, because it uses a different signal generator class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants