Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow instance of Livetime for livetime property #167

Open
martwo opened this issue Aug 22, 2023 · 0 comments
Open

Allow instance of Livetime for livetime property #167

martwo opened this issue Aug 22, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@martwo
Copy link
Collaborator

martwo commented Aug 22, 2023

The livetime property of the DatasetData class should allow to be an instance of core.livetime.Livetime. So derived Dataset classes can construct a Livetime instance if e.g. good-run-list information is available.

skyllh/skyllh/core/dataset.py

Lines 2822 to 2828 in 074c508

@livetime.setter
def livetime(self, lt):
if lt is not None:
lt = float_cast(
lt,
'The livetime property must be castable to type float!')
self._livetime = lt

@martwo martwo self-assigned this Aug 22, 2023
@martwo martwo added the enhancement New feature or request label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant