Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combining all shares of a group throws and error #7

Open
grempe opened this issue Dec 12, 2019 · 1 comment
Open

Combining all shares of a group throws and error #7

grempe opened this issue Dec 12, 2019 · 1 comment

Comments

@grempe
Copy link

grempe commented Dec 12, 2019

Steps to reproduce:

  1. Generate a 2/3 set of shares.
  2. Copy all three shares
  3. Paste all three shares into the Combine > Shares text box

Expected result:
The proper secret is decoded, matching the original secret.

Actual result:
An error is immediately shown in the UI:
Error: Wrong number of mnemonic groups. Expected $groupThreshold groups, but undefined were provided.

This also behaves the same with 3/5 split. Where an error is thrown unless exactly three shares are provided.

It should be possible to reconstruct a split secret from all of the shares, not just threshold shares.

@iancoleman
Copy link
Owner

Yes I agree, where there's excess shares it would be good to use only the required number instead of showing an error. I'll add this feature.

Also related to #6 Improve error messages for share recovery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants