Disable Reflexes

[msminirobot]

Describe the bug
According to the Create 3 Docs, reflexes can be enabled or disabled using the corresponding ROS 2 parameters exposed by the motion_control ROS 2 node. However, the update of the parameter always fails when using ros2 parameter set /motion_control reflexes_enabled false.

To Reproduce
Steps to reproduce the behavior:

1. Launch a simulation of the Create 3 (e.g., the TB4 simulation here: ros2 launch turtlebot4_ignition_bringup turtlebot4_ignition.launch.py)
2. Open a second terminal
3. Execute ros2 parameter set /motion_control reflexes_enabled False
4. See error

Expected behavior
Reflexes_enabled set to False

Additional context
According to this line in Code, set parameters always returns false. In contrast to the comment, reflexes are enabled and executed and cannot be turned off.

[alsora]

Good catch. This is a bug.
The simulator didn't initially implement reflexes, so we forced that parameter to return false.
Then we added reflexes, but we forgot to update the parameter logic.
It should be an easy fix, I'll try to put up a PR in the next few days.

[msminirobot]

Thanks a lot :)