Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weight matrix sharing confusion #24

Open
Jerry-hyl opened this issue Jan 31, 2024 · 0 comments
Open

Weight matrix sharing confusion #24

Jerry-hyl opened this issue Jan 31, 2024 · 0 comments

Comments

@Jerry-hyl
Copy link

In our model, we share the same weight matrix between the two embedding layers and the pre-softmax linear transformation.

Hello! I have the paper recently and find that this part was mentioned in 3.4 Embeddings and Softmax, but your code seemingly consider the embedding layer of ouput and the linear layer before softmax layer as separate ones, so I want to ask what's your consideration of this part?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant