Deposit recovery upon lost state #5
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Geihs <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
===========================================
- Coverage 99.00% 86.58% -12.42%
===========================================
Files 9 9
Lines 200 231 +31
Branches 53 63 +10
===========================================
+ Hits 198 200 +2
- Misses 2 31 +29
Continue to review full report at Codecov.
|
|
The current version requires to fix the deposited funds upon recovery initialization. An alternative would be to conclude the channel with a zero balance in case of a recovery. And when the asset holder detects a zero balance at conclusion, it would automatically leave the initial deposit values untouched. Edit |
matthiasgeihs
force-pushed
the
4-recover-deposit
branch
2 times, most recently
from
638e25d
to
579bff5
Compare
`channelID` is a convenient variable name, so we rename the function to prevent shadowing. Signed-off-by: Matthias Geihs <[email protected]>
matthiasgeihs
force-pushed
the
4-recover-deposit
branch
3 times, most recently
from
0d56a4b
to
bef1060
Compare
Signed-off-by: Matthias Geihs <[email protected]>
Signed-off-by: Matthias Geihs <[email protected]>
Signed-off-by: Matthias Geihs <[email protected]>
matthiasgeihs
force-pushed
the
4-recover-deposit
branch
from
bef1060
to
a2161c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4
This change allows a channel participant to recover its deposited funds from purely on-chain calldata. This is useful in case the channel state has been lost.
The change introduces a method
depositChannelParticipanton the asset holder that records thechannelIDupon funds deposit. Previously, only thefundingIDwould be available via calldata, from which thechannelIDis not recoverable.The adjudicator is augmented with a function
registerDepositRecoverywhich allows a channel participant to initiate deposited funds recovery.