Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SubscribeClient should not panic #220

Open
ggwpez opened this issue Sep 23, 2021 · 0 comments
Open

SubscribeClient should not panic #220

ggwpez opened this issue Sep 23, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@ggwpez
Copy link
Contributor

ggwpez commented Sep 23, 2021 •
edited
Loading

Location

[wire] Localbus.SubscribeClient the close(recv.exists) statement.

Problem

Code panics when it is called twice with the same address.
AFAIK the local bus was only intended for testing and not production usage, so some edge-cases which are not needed for testing were omitted.

Proposal

Return an error instead and add a test+race test.
@ggwpez ggwpez added the bug Something isn't working label Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ggwpez